Issue 922693002: Fix Android build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 922693002: Fix Android build (Closed)

Created:
5 years, 10 months ago by Søren Gjesse

Modified:
5 years, 10 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Android build R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43728

Patch Set 2 : One more fix #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/bin/socket_android.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/922693002/diff/1/runtime/bin/socket_android.cc File runtime/bin/socket_android.cc (right): https://codereview.chromium.org/922693002/diff/1/runtime/bin/socket_android.cc#newcode545 runtime/bin/socket_android.cc:545: memmove(&mreq.gr_group, &addr->ss, SocketAddress::GetAddrLength(addr)); This line needs changed too.

5 years, 10 months ago (2015-02-12 15:05:23 UTC) #2

Søren Gjesse

PTAL https://codereview.chromium.org/922693002/diff/1/runtime/bin/socket_android.cc File runtime/bin/socket_android.cc (right): https://codereview.chromium.org/922693002/diff/1/runtime/bin/socket_android.cc#newcode545 runtime/bin/socket_android.cc:545: memmove(&mreq.gr_group, &addr->ss, SocketAddress::GetAddrLength(addr)); On 2015/02/12 15:05:23, Bill Hesse ...

5 years, 10 months ago (2015-02-12 15:07:11 UTC) #3

Søren Gjesse

5 years, 10 months ago (2015-02-12 15:13:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43728.

Expand Messages | Collapse Messages

Issue 922693002: Fix Android build (Closed)

Description

Patch Set 1 #

Patch Set 2 : One more fix #

Messages