Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 92253003: Attempting to de-flake the fileapi_test (Closed)

Created:
7 years ago by blois
Modified:
7 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Attempting to de-flake the fileapi_test Multiple tests were using the same filenames, but were executing in parallel. Could have caused the flakes observed. BUG=15355 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=30942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M tests/html/fileapi_test.dart View 8 chunks +11 lines, -11 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years ago (2013-11-27 19:16:36 UTC) #1
Emily Fortuna
lgtm
7 years ago (2013-12-02 18:58:00 UTC) #2
blois
7 years ago (2013-12-06 11:31:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30942 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698