Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 922463002: Revert "Redo "Steps towards making dart2js JS AST templates an indepentent library."" (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Redo "Steps towards making dart2js JS AST templates an indepentent library."" Investigating failure of dart2js_incremental. TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -340 lines) Patch
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/compiler/lib/src/js/characters.dart View 1 chunk +0 lines, -117 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +12 lines, -53 lines 0 comments Download
D pkg/compiler/lib/src/js/js_ast.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js/nodes.dart View 10 chunks +32 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js/printer.dart View 14 chunks +73 lines, -113 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js/template.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sra1
5 years, 10 months ago (2015-02-12 01:18:24 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698