Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 922383002: Replace using runtimeType with 'is'. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace using runtimeType with 'is'. This speeds up initial analysis of analyzer + analysis_server on about 4%. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 4 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-13 19:06:05 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-13 19:14:59 UTC) #2
scheglov
5 years, 10 months ago (2015-02-13 19:16:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698