Issue 922163005: Fix HTTP support in vm-service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 922163005: Fix HTTP support in vm-service (Closed)

Created:
5 years, 10 months ago by Cutch

Modified:
5 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix HTTP support in vm-service - Add back Message.fromUri constructor. - Fix 'root' isolateId alias. - FATAL on missing source files when starting up the service isolate. Committed: https://code.google.com/p/dart/source/detail?r=43814

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -1 line)			Patch
M	runtime/bin/vmservice_impl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/service/message.dart	View	2 chunks	+14 lines, -0 lines	1 comment	Download
M	runtime/vm/service/running_isolates.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service_isolate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/922163005/diff/1/runtime/vm/service/message.dart File runtime/vm/service/message.dart (right): https://codereview.chromium.org/922163005/diff/1/runtime/vm/service/message.dart#newcode7 runtime/vm/service/message.dart:7: String methodNameFromUri(Uri uri) { Does this have ...

5 years, 10 months ago (2015-02-14 01:09:51 UTC) #3

Cutch

5 years, 10 months ago (2015-02-17 16:36:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43814 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages