Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 921733002: Update documentation for Platform.version (Closed)

Created:
5 years, 10 months ago by Søren Gjesse
Modified:
5 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update documentation for Platform.version Add test that Platform.version does start with a valid semver string. BUG=http://dartbug/22244 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=43723

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M sdk/lib/io/platform.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Søren Gjesse
5 years, 10 months ago (2015-02-12 12:06:14 UTC) #1
ricow1
lgtm, take the regexp if you want (I use something similar in the validation code ...
5 years, 10 months ago (2015-02-12 12:33:08 UTC) #2
Søren Gjesse
PTAL Made the testing even more rigirous. https://codereview.chromium.org/921733002/diff/1/tests/standalone/io/platform_test.dart File tests/standalone/io/platform_test.dart (right): https://codereview.chromium.org/921733002/diff/1/tests/standalone/io/platform_test.dart#newcode71 tests/standalone/io/platform_test.dart:71: var semver ...
5 years, 10 months ago (2015-02-12 13:04:47 UTC) #4
ricow1
lgtm
5 years, 10 months ago (2015-02-12 13:12:17 UTC) #5
Søren Gjesse
5 years, 10 months ago (2015-02-12 13:36:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698