Fold empty async frames when generating a terse stack trace.

Fold empty async frames when generating a terse stack trace.

This avoids having stack chains with a bunch of useless empty frames.

R=rnystrom@google.com, kevmoo@google.com

Committed: https://github.com/dart-lang/stack_trace/commit/81dba7f46f53ee0f86b1fccc0ec485ba65361483

[Bob Nystrom, 2015-02-12 19:31:45]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-02-12 19:31:45]

lgtm

https://codereview.chromium.org/921553006/diff/1/lib/src/trace.dart
File lib/src/trace.dart (right):

https://codereview.chromium.org/921553006/diff/1/lib/src/trace.dart#newcode211
lib/src/trace.dart:211: // Ignore async stack frames without any line or column
information. These
Do you know if the VM intends to always have these in stack traces, or are they
a temporary artifact? If the latter, can you add a TODO with the relevant bug
here?

[nweiz, 2015-02-12 19:56:56]

New patchsets have been uploaded after l-g-t-m from rnystrom@google.com

[nweiz, 2015-02-12 19:56:57]

Code review changes

[nweiz, 2015-02-12 19:57:01]

https://codereview.chromium.org/921553006/diff/1/lib/src/trace.dart
File lib/src/trace.dart (right):

https://codereview.chromium.org/921553006/diff/1/lib/src/trace.dart#newcode211
lib/src/trace.dart:211: // Ignore async stack frames without any line or column
information. These
On 2015/02/12 19:31:45, Bob Nystrom wrote:
> Do you know if the VM intends to always have these in stack traces, or are
they
> a temporary artifact? If the latter, can you add a TODO with the relevant bug
> here?

Done.

[nweiz, 2015-02-12 19:57:11]

Committed patchset #2 (id:20001) manually as
81dba7f46f53ee0f86b1fccc0ec485ba65361483 (presubmit successful).