Visit async and core library dependencies when computing library cycles.

Visit async and core library dependencies when computing library cycles.

Previously, we would create the Library objects for the core and async
libraries before calling _computeLibraryDependencies().  As a result,
_computeLibraryDependencies() would skip those libraries when
computing dependencies.  Normally this was not a problem, because the
dependencies surrounding the core and async libraries are so richly
intertwined that all of the necessary files got included in the cycle
anyhow.  However if the starting point of analysis was the
"dart:async" library, some files would be missed entirely, leading to
bogus warnings.

The solution is to let _computeLibraryDependencies() create all the
Library objects, even for the core and async libraries; this way it
won't skip any dependencies.

BUG=dartbug.com/22415
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43772

[Paul Berry, 2015-02-13 17:10:38]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-02-13 17:32:27]

LGTM

https://codereview.chromium.org/921213002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/921213002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:7916: // on core, and we inject an
ersatz dependency on async, so once this is
Is it really necessary to inject a dependency on dart:async? dart:core
explicitly imports dart:convert, which in turn explicitly imports dart:async.

[Paul Berry, 2015-02-13 18:14:58]

On 2015/02/13 17:32:27, Brian Wilkerson wrote:
> LGTM
> 
>
https://codereview.chromium.org/921213002/diff/1/pkg/analyzer/lib/src/generat...
> File pkg/analyzer/lib/src/generated/resolver.dart (right):
> 
>
https://codereview.chromium.org/921213002/diff/1/pkg/analyzer/lib/src/generat...
> pkg/analyzer/lib/src/generated/resolver.dart:7916: // on core, and we inject
an
> ersatz dependency on async, so once this is
> Is it really necessary to inject a dependency on dart:async? dart:core
> explicitly imports dart:convert, which in turn explicitly imports dart:async.

We discussed this briefly before but never came to a conclusion - see
https://codereview.chromium.org//898513002#msg4

Let's discuss today.

[Paul Berry, 2015-02-13 18:52:47]

Committed patchset #1 (id:1) manually as 43772 (presubmit successful).