Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 921163004: Add LibraryDependencyMirror.isDeferred. (Closed)

Created:
5 years, 10 months ago by rmacnak
Modified:
5 years, 10 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : sync + year fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -9 lines) Patch
M runtime/lib/mirrors.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/library_imports_deferred_test.dart View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M tests/lib/mirrors/stringify.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rmacnak
5 years, 10 months ago (2015-02-13 23:53:14 UTC) #2
gbracha
tests and API lgtm with minor comment. https://codereview.chromium.org/921163004/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/921163004/diff/1/sdk/lib/mirrors/mirrors.dart#newcode608 sdk/lib/mirrors/mirrors.dart:608: /// false. ...
5 years, 10 months ago (2015-02-14 00:09:00 UTC) #3
siva
https://codereview.chromium.org/921163004/diff/1/tests/lib/mirrors/library_imports_deferred_test.dart File tests/lib/mirrors/library_imports_deferred_test.dart (right): https://codereview.chromium.org/921163004/diff/1/tests/lib/mirrors/library_imports_deferred_test.dart#newcode11 tests/lib/mirrors/library_imports_deferred_test.dart:11: import 'dart:collection' deferred as lazycollection; Need to add a ...
5 years, 10 months ago (2015-02-14 00:25:22 UTC) #4
rmacnak
https://codereview.chromium.org/921163004/diff/1/tests/lib/mirrors/library_imports_deferred_test.dart File tests/lib/mirrors/library_imports_deferred_test.dart (right): https://codereview.chromium.org/921163004/diff/1/tests/lib/mirrors/library_imports_deferred_test.dart#newcode11 tests/lib/mirrors/library_imports_deferred_test.dart:11: import 'dart:collection' deferred as lazycollection; On 2015/02/14 00:25:22, siva ...
5 years, 10 months ago (2015-02-14 00:37:54 UTC) #6
gbracha
still lgtm
5 years, 10 months ago (2015-02-14 00:41:05 UTC) #7
siva
lgtm
5 years, 10 months ago (2015-02-17 23:45:14 UTC) #8
rmacnak
5 years, 10 months ago (2015-02-17 23:49:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698