Add a Loader class for loading tests from files.

Add a Loader class for loading tests from files.

R=kevmoo@google.com
See #2

Committed: https://github.com/dart-lang/unittest/commit/f075c79a8c10bbdcefc15622d4d389d0de6102ef

[kevmoo, 2015-02-12 22:31:15]

lgtm

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart
File lib/src/dart.dart (right):

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart#newcode12
lib/src/dart.dart:12: import 'package:stack_trace/stack_trace.dart';
unused import

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart#newcode14
lib/src/dart.dart:14: import 'remote_exception.dart';
sort

https://codereview.chromium.org/920703006/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/920703006/diff/1/lib/src/io.dart#newcode38
lib/src/io.dart:38: .whenComplete(() => tempDir.deleteSync(recursive: true));
If tests are being run on many isolates, do we want to avoid blocking IO to
increase throughput?

-Sync

https://codereview.chromium.org/920703006/diff/1/test/loader_test.dart
File test/loader_test.dart (right):

https://codereview.chromium.org/920703006/diff/1/test/loader_test.dart#newcode39
test/loader_test.dart:39: _loader.close();
Wait on the close future –> it might matter if code is refactored...in the
future

[nweiz, 2015-02-12 22:37:45]

New patchsets have been uploaded after l-g-t-m from kevmoo@google.com

[nweiz, 2015-02-12 22:37:45]

Code review changes

[nweiz, 2015-02-12 22:37:52]

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart
File lib/src/dart.dart (right):

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart#newcode12
lib/src/dart.dart:12: import 'package:stack_trace/stack_trace.dart';
On 2015/02/12 22:31:15, kevmoo wrote:
> unused import

Done.

https://codereview.chromium.org/920703006/diff/1/lib/src/dart.dart#newcode14
lib/src/dart.dart:14: import 'remote_exception.dart';
On 2015/02/12 22:31:15, kevmoo wrote:
> sort

Done.

https://codereview.chromium.org/920703006/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/920703006/diff/1/lib/src/io.dart#newcode38
lib/src/io.dart:38: .whenComplete(() => tempDir.deleteSync(recursive: true));
On 2015/02/12 22:31:15, kevmoo wrote:
> If tests are being run on many isolates, do we want to avoid blocking IO to
> increase throughput?
> 
> -Sync

Evidence so far indicates that sync IO functions are noticeably faster than
async; at least in pub, there's enough of a difference that it outweighs the
parallelism benefits. I think that's a good assumption here, but I'll add a TODO
to test empirically.

https://codereview.chromium.org/920703006/diff/1/test/loader_test.dart
File test/loader_test.dart (right):

https://codereview.chromium.org/920703006/diff/1/test/loader_test.dart#newcode39
test/loader_test.dart:39: _loader.close();
On 2015/02/12 22:31:15, kevmoo wrote:
> Wait on the close future –> it might matter if code is refactored...in the
> future

Done.

[nweiz, 2015-02-12 22:38:10]

Committed patchset #2 (id:20001) manually as
f075c79a8c10bbdcefc15622d4d389d0de6102ef (presubmit successful).