Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 920703002: cps2js: Clean up some obsolete TODOs. (Closed)

Created:
5 years, 10 months ago by asgerf
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps2js: Clean up some obsolete TODOs. Also added DartSpecificNode interface for CPS and tree nodes that are specific to the Dart backend. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43949

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -37 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 4 chunks +10 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 6 chunks +28 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
5 years, 10 months ago (2015-02-12 10:39:25 UTC) #2
asgerf
https://codereview.chromium.org/920703002/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (left): https://codereview.chromium.org/920703002/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#oldcode345 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:345: // TODO(sigurdm): Inside a js closure this will not ...
5 years, 10 months ago (2015-02-12 10:40:20 UTC) #3
sigurdm
LGTM
5 years, 10 months ago (2015-02-12 11:04:57 UTC) #4
asgerf
5 years, 10 months ago (2015-02-23 11:35:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698