Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 920673002: Archive more debug builds for manual inspection of binary differences (Closed)

Created:
5 years, 10 months ago by ricow1
Modified:
5 years, 10 months ago
Reviewers:
koda
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Archive more debug builds for manual inspection of binary differences R=koda@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43713

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix path of binary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M tools/archive_crash.py View 1 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
5 years, 10 months ago (2015-02-12 06:52:53 UTC) #1
ricow1
https://codereview.chromium.org/920673002/diff/1/tools/archive_crash.py File tools/archive_crash.py (right): https://codereview.chromium.org/920673002/diff/1/tools/archive_crash.py#newcode45 tools/archive_crash.py:45: CopyToGCS('%s/out/DebugX64/dart' % pwd) fixing this, clearly wrong
5 years, 10 months ago (2015-02-12 06:54:59 UTC) #2
ricow1
fixed path, ptal
5 years, 10 months ago (2015-02-12 07:11:41 UTC) #3
ricow1
tbr
5 years, 10 months ago (2015-02-12 07:23:04 UTC) #4
ricow1
5 years, 10 months ago (2015-02-12 07:24:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43713 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698