Issue 920473002: Fix race condition in tests/standalone/io/file_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 920473002: Fix race condition in tests/standalone/io/file_test (Closed)

Created:
5 years, 10 months ago by kustermann

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix race condition in tests/standalone/io/file_test R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43683

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -33 lines)			Patch
	M	dart/tests/standalone/io/file_test.dart	View		2 chunks	+43 lines, -33 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

Should fix the following flake: http://build.chromium.org/p/client.dart/builders/vm-win32-debug-be/builds/5594/steps/checked_tests/logs/stdio https://codereview.chromium.org/920473002/diff/1/dart/tests/standalone/io/file_test.dart File dart/tests/standalone/io/file_test.dart (left): https://codereview.chromium.org/920473002/diff/1/dart/tests/standalone/io/file_test.dart#oldcode179 dart/tests/standalone/io/file_test.dart:179: .then((_) => file.delete()) ...

5 years, 10 months ago (2015-02-11 13:38:23 UTC) #1

kustermann

5 years, 10 months ago (2015-02-11 14:33:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43683 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages