Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 920373003: Fix behavior when listening multiple times to a broadcast take/skip stream. (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix behavior when listening multiple times to a broadcast take/skip stream. Turns out the existing behavior was badly broken. A broadcastStream.take(10) would only produce ten events total, no matter how many listeners were attached, beacuse the counter was on the stream, not the subscription. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43755

Patch Set 1 #

Patch Set 2 : Add tests. #

Total comments: 1

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -22 lines) Patch
M sdk/lib/async/stream_pipe.dart View 1 2 5 chunks +66 lines, -13 lines 0 comments Download
M tests/lib/async/stream_transformation_broadcast_test.dart View 1 2 chunks +187 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
All tests run after the change, so I'll add tests for the broken behavior too.
5 years, 10 months ago (2015-02-13 12:43:46 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/920373003/diff/20001/sdk/lib/async/stream_pipe.dart File sdk/lib/async/stream_pipe.dart (right): https://codereview.chromium.org/920373003/diff/20001/sdk/lib/async/stream_pipe.dart#newcode348 sdk/lib/async/stream_pipe.dart:348: * Use by several different classes, some storeing ...
5 years, 10 months ago (2015-02-13 13:52:56 UTC) #3
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-13 13:59:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698