Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 920113002: Add getCallSiteData to the VM service. (Closed)

Created:
5 years, 10 months ago by rmacnak
Modified:
5 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add getCallSiteData to the VM service. Committed: https://code.google.com/p/dart/source/detail?r=43740

Patch Set 1 #

Patch Set 2 : sync'd #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -0 lines) Patch
A runtime/observatory/test/call_site_data_test.dart View 1 2 1 chunk +118 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +65 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 2 chunks +39 lines, -0 lines 0 comments Download
M runtime/vm/service/service.idl View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 10 months ago (2015-02-12 19:32:15 UTC) #2
rmacnak
sync'd
5 years, 10 months ago (2015-02-12 20:31:18 UTC) #3
Cutch
LGTMwC https://codereview.chromium.org/920113002/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/920113002/diff/20001/runtime/vm/service.cc#newcode1493 runtime/vm/service.cc:1493: NULL, Should be: ISOLATE_PARAMETER, new IdParameter("targetId", true)", NULL, ...
5 years, 10 months ago (2015-02-12 20:38:02 UTC) #4
rmacnak
https://codereview.chromium.org/920113002/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/920113002/diff/20001/runtime/vm/service.cc#newcode1493 runtime/vm/service.cc:1493: NULL, On 2015/02/12 20:38:02, Cutch wrote: > Should be: ...
5 years, 10 months ago (2015-02-12 20:55:13 UTC) #5
rmacnak
5 years, 10 months ago (2015-02-12 20:55:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698