Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 919983003: Get rid of minified tests. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/matcher@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of minified tests. We aren't running the tests against minified dart2js, and we don't particularly want to. R=kevmoo@google.com Committed: https://github.com/dart-lang/matcher/commit/3c8ee6911878a8375fa36f4011f930433ccc06c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -248 lines) Patch
M .status View 1 chunk +0 lines, -12 lines 0 comments Download
M test/core_matchers_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M test/iterable_matchers_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
D test/minified_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D test/pretty_print_minified_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
M test/pretty_print_test.dart View 2 chunks +43 lines, -0 lines 0 comments Download
D test/pretty_print_unminified_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D test/unminified_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 10 months ago (2015-02-19 00:58:52 UTC) #1
kevmoo
5 years, 10 months ago (2015-02-19 01:10:20 UTC) #2
kevmoo
lgtm
5 years, 10 months ago (2015-02-19 01:10:26 UTC) #3
nweiz
5 years, 10 months ago (2015-02-19 01:19:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c8ee6911878a8375fa36f4011f930433ccc06c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698