Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 919173002: Added the ScriptCompactor, ImportInliner, HtmlImportAnnotationRecorder, and WebComponentsTransforme… (Closed)

Created:
5 years, 10 months ago by jakemac
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added the ScriptCompactor, ImportInliner, HtmlImportAnnotationRecorder, and WebComponentsTransformer, as well as the WebComponentsTransformerGroup which combines this all together. R=sigmund@google.com Committed: https://github.com/dart-lang/core-elements/commit/2f544a773e509c9f1bc43e02ca6ce8a7caf32117

Patch Set 1 #

Total comments: 100

Patch Set 2 : address most code review comments #

Patch Set 3 : remove binding specific logic #

Total comments: 9

Patch Set 4 : code review round 2 #

Patch Set 5 : remove uri parse warning #

Patch Set 6 : added an e2e html import test #

Total comments: 3

Patch Set 7 : update pubspec/changelog #

Patch Set 8 : pubspec format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2803 lines, -233 lines) Patch
M CHANGELOG.md View 1 2 3 4 5 6 2 chunks +16 lines, -11 lines 0 comments Download
A e2e_test/html_imports/lib/theme.html View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A e2e_test/html_imports/pubspec.yaml View 1 2 3 4 5 6 7 1 chunk +11 lines, -0 lines 0 comments Download
A e2e_test/html_imports/test/basic_test.dart View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
A e2e_test/html_imports/test/basic_test.html View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A lib/build/common.dart View 1 chunk +78 lines, -0 lines 0 comments Download
D lib/build/html_import_annotation_inliner.dart View 1 chunk +0 lines, -124 lines 0 comments Download
A lib/build/html_import_annotation_recorder.dart View 1 1 chunk +95 lines, -0 lines 0 comments Download
A lib/build/import_crawler.dart View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A lib/build/import_inliner.dart View 1 2 3 4 1 chunk +347 lines, -0 lines 0 comments Download
A lib/build/messages.dart View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A lib/build/script_compactor.dart View 1 2 3 1 chunk +261 lines, -0 lines 0 comments Download
A lib/build/web_components.dart View 1 1 chunk +118 lines, -0 lines 0 comments Download
A lib/transformer.dart View 1 1 chunk +111 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 3 4 5 6 2 chunks +16 lines, -18 lines 0 comments Download
A test/build/common.dart View 1 chunk +27 lines, -0 lines 0 comments Download
D test/build/html_import_annotation_inliner_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
A test/build/html_import_annotation_recorder_test.dart View 1 1 chunk +105 lines, -0 lines 0 comments Download
A test/build/import_crawler_test.dart View 1 2 3 1 chunk +94 lines, -0 lines 0 comments Download
A test/build/import_inliner_test.dart View 1 2 3 4 1 chunk +792 lines, -0 lines 0 comments Download
A test/build/script_compactor_test.dart View 1 1 chunk +433 lines, -0 lines 0 comments Download
A test/build/transformer_test.dart View 1 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (3 generated)
jakemac
Round 2 on the WebComponents transformer
5 years, 10 months ago (2015-02-12 22:29:22 UTC) #2
Siggi Cherem (dart-lang)
very cool Jake! I haven't finished reviewing, but I wanted to share what I have ...
5 years, 10 months ago (2015-02-13 02:40:34 UTC) #3
jakemac
5 years, 10 months ago (2015-02-13 17:10:45 UTC) #4
Siggi Cherem (dart-lang)
still very cool! The rest of the comments :) https://codereview.chromium.org/919173002/diff/1/lib/build/web_components.dart File lib/build/web_components.dart (right): https://codereview.chromium.org/919173002/diff/1/lib/build/web_components.dart#newcode19 lib/build/web_components.dart:19: ...
5 years, 10 months ago (2015-02-13 17:20:05 UTC) #5
jakemac
Addressed everything except the bindings stuff, I will follow up with that a bit later ...
5 years, 10 months ago (2015-02-13 22:08:09 UTC) #6
jakemac
ok I removed the binding specific logic now, yay!
5 years, 10 months ago (2015-02-13 23:15:18 UTC) #7
Siggi Cherem (dart-lang)
https://codereview.chromium.org/919173002/diff/1/lib/build/script_compactor.dart File lib/build/script_compactor.dart (right): https://codereview.chromium.org/919173002/diff/1/lib/build/script_compactor.dart#newcode25 lib/build/script_compactor.dart:25: /// this when inlining imports into your entry point. ...
5 years, 10 months ago (2015-02-14 00:16:16 UTC) #8
jakemac
https://codereview.chromium.org/919173002/diff/1/lib/build/script_compactor.dart File lib/build/script_compactor.dart (right): https://codereview.chromium.org/919173002/diff/1/lib/build/script_compactor.dart#newcode25 lib/build/script_compactor.dart:25: /// this when inlining imports into your entry point. ...
5 years, 10 months ago (2015-02-17 15:23:01 UTC) #9
Siggi Cherem (dart-lang)
nice, one more thing to chat about later today, but other than that it looks ...
5 years, 10 months ago (2015-02-17 16:17:27 UTC) #10
jakemac
On 2015/02/17 16:17:27, Siggi Cherem (dart-lang) wrote: > nice, one more thing to chat about ...
5 years, 10 months ago (2015-02-17 16:24:36 UTC) #11
Siggi Cherem (dart-lang)
On 2015/02/17 16:24:36, jakemac wrote: > On 2015/02/17 16:17:27, Siggi Cherem (dart-lang) wrote: > > ...
5 years, 10 months ago (2015-02-17 16:35:18 UTC) #12
jakemac
added an e2e test and removed the warning we talked about
5 years, 10 months ago (2015-02-17 21:10:18 UTC) #13
Siggi Cherem (dart-lang)
lgtm! Thanks Jake! https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml#newcode17 pubspec.yaml:17: initialize: '>=0.5.0 <0.6.0' FYI - there ...
5 years, 10 months ago (2015-02-17 21:12:31 UTC) #14
kevmoo
DBC https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml#newcode17 pubspec.yaml:17: initialize: '>=0.5.0 <0.6.0' On 2015/02/17 21:12:31, Siggi Cherem ...
5 years, 10 months ago (2015-02-17 21:15:29 UTC) #16
jakemac
https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/919173002/diff/90001/pubspec.yaml#newcode17 pubspec.yaml:17: initialize: '>=0.5.0 <0.6.0' On 2015/02/17 21:15:29, kevmoo wrote: > ...
5 years, 10 months ago (2015-02-17 21:27:16 UTC) #18
jakemac
5 years, 10 months ago (2015-02-17 21:58:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #8 (id:130001) manually as
2f544a773e509c9f1bc43e02ca6ce8a7caf32117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698