Issue 919063002: Increase verbosity of assertion failures in SizeFromClass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 919063002: Increase verbosity of assertion failures in SizeFromClass. (Closed)

Created:
5 years, 10 months ago by koda

Modified:
5 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Increase verbosity of assertion failures in SizeFromClass. Print the tag word for which the assertion fails. This is specifically to help tracking down issue 22087. TBR=iposva@google.com BUG=dart:22087 Committed: https://code.google.com/p/dart/source/detail?r=43732

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	runtime/platform/assert.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	runtime/vm/raw_object.cc	View		2 chunks	+16 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

koda

Committed patchset #1 (id:1) manually as r43732 (presubmit successful).

5 years, 10 months ago (2015-02-12 18:09:00 UTC) #1

Message was sent while issue was closed.

LGTM -ip