Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 918893003: Revert "Remove implicit dependencies." (Closed)

Created:
5 years, 10 months ago by ahe
Modified:
5 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove implicit dependencies." This reverts r43874. Revert "Register literals through backend." This reverts r43876. FAILED: dart2js-d8-checked release_ia32 utils/source_mirrors_test out/ReleaseIA32/dart-sdk/lib/_internal/compiler/js_lib/preambles/d8.js:263: Uncaught Error: Invalid argument(s): "_Proxy" is a private identifier Stack Trace: Error at dart.wrapException (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:2990:15) at dart.Symbol0.static.Symbol_validatePublicSymbol (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:11047:19) That is, attempting to create a symbol for _Proxy, which is something I did change. Also, many dart2dart fails with errors like this: Internal Error: Function signature has not been computed for function(Symbol#). const factory Symbol(String name) = internal.Symbol; ^^^^^^ Also something that I changed. Committed: https://code.google.com/p/dart/source/detail?r=43878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -147 lines) Patch
M dart/pkg/compiler/lib/src/compiler.dart View 6 chunks +15 lines, -28 lines 0 comments Download
M dart/pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_backend/backend.dart View 4 chunks +1 line, -53 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 9 chunks +19 lines, -24 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M dart/tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
TBR
5 years, 10 months ago (2015-02-19 15:30:58 UTC) #2
ahe
Committed patchset #1 (id:1) manually as 43878 (presubmit successful).
5 years, 10 months ago (2015-02-19 15:31:53 UTC) #3
Johnni Winther
5 years, 10 months ago (2015-02-19 15:34:42 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698