Issue 918853005: Get new tests working on dart2js.

Issue 918853005: Get new tests working on dart2js. (Closed)

Created:
5 years, 10 months ago by nweiz

Modified:
5 years, 10 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/unittest@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Get new tests working on dart2js. This fixes tests that don't require dart:io and marks those that do dart:io as Skip. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/f07e3a3cc8dc7fc05f3965c8d69247f3373c7dcc

Patch Set 2 : Code review changes #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -19 lines)			Patch
M	.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/invoker.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download
A	test/io.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	test/loader_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/utils.dart	View		3 chunks	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

lgtm https://codereview.chromium.org/918853005/diff/1/.status File .status (right): https://codereview.chromium.org/918853005/diff/1/.status#newcode25 .status:25: build/test/loader_test: Skip SkipByDesign Trying to encourage folks to ...

5 years, 10 months ago (2015-02-12 22:54:15 UTC) #2

nweiz

https://codereview.chromium.org/918853005/diff/1/.status File .status (right): https://codereview.chromium.org/918853005/diff/1/.status#newcode25 .status:25: build/test/loader_test: Skip On 2015/02/12 22:54:15, kevmoo wrote: > SkipByDesign ...

5 years, 10 months ago (2015-02-12 23:11:58 UTC) #5

nweiz

5 years, 10 months ago (2015-02-12 23:12:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f07e3a3cc8dc7fc05f3965c8d69247f3373c7dcc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages