Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 918823002: Fix race condition an isolate is being added to the isolate list before the name for the isolate is… (Closed)

Created:
5 years, 10 months ago by siva
Modified:
5 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix race condition an isolate is being added to the isolate list before the name for the isolate is setup, the service isolate starts registering the isolate and accesses the name which is NULL. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M runtime/vm/isolate.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 10 months ago (2015-02-11 23:33:55 UTC) #2
Cutch
5 years, 10 months ago (2015-02-11 23:34:55 UTC) #3
Cutch
lgtm
5 years, 10 months ago (2015-02-11 23:35:08 UTC) #4
siva
5 years, 10 months ago (2015-02-11 23:39:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698