Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 918383002: Rework analysis server performance measurement code. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework analysis server performance measurement code. This change has the following advantages: - We now keep track of the amount of time spent doing unknown activities using its own timer. - Several pieces of analysis server functionality are now tracked (previously we only tracked time spent inside the "analyzer" package). - The set of all performance timers is tracked in PerformanceTag.all so that new timers can be added without having to update the code that prints out timing measurements. - Performance measurement code has been integrated with Observatory "user tags", so that the same categories measured by the analysis server also show up in the VM profiler view. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -188 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +40 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 2 chunks +3 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 3 chunks +17 lines, -4 lines 0 comments Download
M pkg/analyzer/bin/analyzer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 3 chunks +19 lines, -28 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 10 chunks +23 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 28 chunks +40 lines, -42 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +2 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 1 chunk +89 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-12 22:38:31 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-12 22:53:50 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-12 23:55:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698