Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917783003: Add Declarer and Group classes. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Declarer and Group classes. These provide the core test-declaration API. R=kevmoo@google.com See #2 Committed: https://github.com/dart-lang/unittest/commit/8ad00bda9a5c668f741b0d4be5d2bc5bcdee22e3

Patch Set 1 #

Patch Set 2 : _runTest docs #

Total comments: 6

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -0 lines) Patch
A lib/src/declarer.dart View 1 chunk +94 lines, -0 lines 0 comments Download
A lib/src/group.dart View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A test/declarer_test.dart View 1 1 chunk +326 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
5 years, 10 months ago (2015-02-11 19:38:57 UTC) #1
kevmoo
https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart File lib/src/group.dart (right): https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart#newcode23 lib/src/group.dart:23: Function setUp; AsyncFunction? https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart#newcode26 lib/src/group.dart:26: Function tearDown; AsyncFunction? https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart#newcode31 ...
5 years, 10 months ago (2015-02-11 19:57:31 UTC) #2
kevmoo
LGTM w/ previous comments
5 years, 10 months ago (2015-02-11 19:57:45 UTC) #3
nweiz
Code review changes
5 years, 10 months ago (2015-02-11 21:31:27 UTC) #5
nweiz
https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart File lib/src/group.dart (right): https://codereview.chromium.org/917783003/diff/20001/lib/src/group.dart#newcode23 lib/src/group.dart:23: Function setUp; On 2015/02/11 19:57:31, kevmoo wrote: > AsyncFunction? ...
5 years, 10 months ago (2015-02-11 21:32:54 UTC) #6
nweiz
5 years, 10 months ago (2015-02-11 21:33:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8ad00bda9a5c668f741b0d4be5d2bc5bcdee22e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698