Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 917663004: Revert "Add String.replaceFirstMapped." (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add String.replaceFirstMapped." Changes to interpolation should be separate CL. Committed: https://code.google.com/p/dart/source/detail?r=43717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -286 lines) Patch
M runtime/lib/string_patch.dart View 7 chunks +24 lines, -53 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_string.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/string_helper.dart View 1 chunk +7 lines, -20 lines 0 comments Download
M sdk/lib/core/string.dart View 2 chunks +1 line, -15 lines 0 comments Download
M tests/corelib/string_replace_test.dart View 1 chunk +65 lines, -188 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-12 09:12:16 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698