Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 917503002: pkg/unittest: trying again with status failures (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
Any ideas? http://build.chromium.org/p/client.dart.packages/builders/packages-mac-unittest/builds/83/steps/annotated_steps/logs/stdio
5 years, 10 months ago (2015-02-10 23:54:26 UTC) #2
nweiz
lgtm
5 years, 10 months ago (2015-02-10 23:58:14 UTC) #3
kevmoo
5 years, 10 months ago (2015-02-11 00:05:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
000878c67b251101e4c0a8b3406a62c9fceb30c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698