Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917423002: Add a "terse" argument to foldFrames(). (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -45 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/chain.dart View 2 chunks +8 lines, -17 lines 0 comments Download
M lib/src/trace.dart View 1 2 chunks +42 lines, -27 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/chain_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M test/trace_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 10 months ago (2015-02-13 02:17:57 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/917423002/diff/1/lib/src/trace.dart File lib/src/trace.dart (right): https://codereview.chromium.org/917423002/diff/1/lib/src/trace.dart#newcode230 lib/src/trace.dart:230: // Ignore async stack frames without any line ...
5 years, 10 months ago (2015-02-13 16:07:19 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-17 21:41:38 UTC) #4
nweiz
https://codereview.chromium.org/917423002/diff/1/lib/src/trace.dart File lib/src/trace.dart (right): https://codereview.chromium.org/917423002/diff/1/lib/src/trace.dart#newcode230 lib/src/trace.dart:230: // Ignore async stack frames without any line or ...
5 years, 10 months ago (2015-02-17 21:42:34 UTC) #5
nweiz
5 years, 10 months ago (2015-02-17 21:42:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cf520f405358ae95069407777f9f27668cf19979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698