Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 917353003: Fix more status file stuff. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more status file stuff. Run tests from test/ rather than build/test so that their assumptions about paths hold true, fix a typo in the vm_listener_test line, and mark prints_matcher_test failing on Safari. R=kevmoo@google.com TBR See #4 Committed: https://github.com/dart-lang/unittest/commit/121baf57a5fec03e031c702e2cf62a309c5dd6c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M .status View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 10 months ago (2015-02-12 23:32:31 UTC) #1
nweiz
Committed patchset #1 (id:1) manually as 121baf57a5fec03e031c702e2cf62a309c5dd6c1 (presubmit successful).
5 years, 10 months ago (2015-02-12 23:32:39 UTC) #2
kevmoo
5 years, 10 months ago (2015-02-12 23:38:12 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698