Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 917083003: Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class." (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class." I'm reverting this CL because it leaves so many bots red. You should be able to create a branhc, revert this CL, upload, fix the problem, upload again and get a code review of the fixes without the reviewer needing to review the whole CL, just the delta. These tests fail (many browser bots are red since they run the same test): python tools/test.py -mrelease -cdart2js -rff --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --dart2js-batch -t60 html/custom_element_method_clash_test python tools/test.py -mrelease -rdrt --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --checked -t240 try/web/incremental_compilation_update_test TBR=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=43739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -960 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 7 chunks +19 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 18 chunks +319 lines, -656 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 7 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 7 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
D tests/html/custom_element_method_clash_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/html/custom_element_name_clash_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language/constructor_name_clash_lib.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language/constructor_name_clash_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/is_operator_clash_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/language/named_parameter_clash_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/private_clash_lib.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language/private_clash_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as 43739 (presubmit successful).
5 years, 10 months ago (2015-02-12 20:34:01 UTC) #2
sra1
5 years, 10 months ago (2015-02-12 20:39:39 UTC) #3
Message was sent while issue was closed.
More tests that fail with original CL:

python tools/test.py -mrelease -cdart2analyzer -rnone --host-checked
--write-debug-log --write-test-outcome-log -t240
pkg/docgen/test/single_library_test

python tools/test.py -mrelease -cdart2js -rd8 --use-sdk --write-debug-log
--write-test-outcome-log --clear_browser_cache --checked --dart2js-batch
--host-checked -t1920 dart2js_extra/closure_capture2_test

Powered by Google App Engine
This is Rietveld 408576698