Add an Invoker class that manages a running test.

Add an Invoker class that manages a running test.

R=kevmoo@google.com
See #2

Committed: https://github.com/dart-lang/unittest/commit/85377393a74cce198859c73a101824897dcb24f9

[kevmoo, 2015-02-11 00:35:09]

lgtm

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart
File lib/src/invoker.dart (right):

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode24
lib/src/invoker.dart:24: final Function _body;
Consider adding a matching typedef for this is utils.

This typedef "shape" is used all over. It'll help catch analysis bugs and will
make DDC happier

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode60
lib/src/invoker.dart:60: var _outstandingCallbacks = 0;
int -> guard against invalid assignment

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode140
lib/src/invoker.dart:140: // TODO(nweiz): Reset this timer whenever the user's
code interacts with the
long line

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode160
lib/src/invoker.dart:160: // Explicitly handle an error here so that we can
return the [Future]. If
long line

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart
File test/invoker_test.dart (right):

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:18: State lastState;
If things are not used by another lib, make them private.

The analyzer will help us track unused private members.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:504: void expectStates(LiveTest liveTest, Iterable<State>
states) {
Make these helpers private

[kevmoo, 2015-02-11 01:18:28]

Fix these before committing to make sure the analyzer doesn't blow up

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart
File test/invoker_test.dart (right):

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:505: states = new Queue.from(states);
Don't change the type of the var – the analyzer borks on this.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:515: validators = new Queue.from(validators);
Don't change the type of the var – the analyzer borks on this.

[nweiz, 2015-02-11 02:06:48]

New patchsets have been uploaded after l-g-t-m from kevmoo@google.com

[nweiz, 2015-02-11 02:06:50]

Code review changes

[nweiz, 2015-02-11 02:07:06]

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart
File lib/src/invoker.dart (right):

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode24
lib/src/invoker.dart:24: final Function _body;
On 2015/02/11 00:35:09, kevmoo wrote:
> Consider adding a matching typedef for this is utils.
> 
> This typedef "shape" is used all over. It'll help catch analysis bugs and will
> make DDC happier

Done.

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode60
lib/src/invoker.dart:60: var _outstandingCallbacks = 0;
On 2015/02/11 00:35:09, kevmoo wrote:
> int -> guard against invalid assignment

The definition makes it clear that this is an int and the tests make it clear
that it's not being assigned incorrectly.

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode140
lib/src/invoker.dart:140: // TODO(nweiz): Reset this timer whenever the user's
code interacts with the
On 2015/02/11 00:35:09, kevmoo wrote:
> long line

Done.

https://codereview.chromium.org/916533003/diff/1/lib/src/invoker.dart#newcode160
lib/src/invoker.dart:160: // Explicitly handle an error here so that we can
return the [Future]. If
On 2015/02/11 00:35:09, kevmoo wrote:
> long line

Done.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart
File test/invoker_test.dart (right):

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:18: State lastState;
On 2015/02/11 00:35:09, kevmoo wrote:
> If things are not used by another lib, make them private.
> 
> The analyzer will help us track unused private members.

Done.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:504: void expectStates(LiveTest liveTest, Iterable<State>
states) {
On 2015/02/11 00:35:09, kevmoo wrote:
> Make these helpers private

Done.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:505: states = new Queue.from(states);
On 2015/02/11 01:18:28, kevmoo wrote:
> Don't change the type of the var –&nbsp;the analyzer borks on this.

Done.

https://codereview.chromium.org/916533003/diff/1/test/invoker_test.dart#newco...
test/invoker_test.dart:515: validators = new Queue.from(validators);
On 2015/02/11 01:18:28, kevmoo wrote:
> Don't change the type of the var –&nbsp;the analyzer borks on this.

Done.

[nweiz, 2015-02-11 02:07:41]

Committed patchset #2 (id:20001) manually as
85377393a74cce198859c73a101824897dcb24f9 (presubmit successful).