Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 916413002: dart2js: register holder of constant in initial value of a static field. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: register holder of constant in initial value of a static field. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zarah
5 years, 10 months ago (2015-02-12 12:59:14 UTC) #2
floitsch
LGTM.
5 years, 10 months ago (2015-02-13 21:01:49 UTC) #3
floitsch
Fwiw: the "holder" concept is something specific to the Emitter. Even though it means that ...
5 years, 10 months ago (2015-02-13 21:02:59 UTC) #4
zarah
5 years, 10 months ago (2015-02-16 11:05:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698