Issue 916403002: cps2js: Fix translation of captured 'this'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 916403002: cps2js: Fix translation of captured 'this'. (Closed)

Created:
5 years, 10 months ago by asgerf

Modified:
5 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

cps2js: Fix translation of captured 'this'. Building the constructor call for a closure that captures 'this' would fail because the ThisLocal is not bound in the enclosing environment. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=43945

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

5 years, 10 months ago (2015-02-23 09:38:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43945 (presubmit successful).