Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 915723002: Make ASAN/MSAN ignore Dart frames. (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make ASAN/MSAN ignore Dart frames. Frames initialized by generated code are unknown to ASAN/MSAN, so we must explicitly mark it as initialized. For some (unknown) reason, this only caused failures on the build bot. TBR=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M runtime/vm/profiler.cc View 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
5 years, 10 months ago (2015-02-10 18:35:11 UTC) #1
koda
Submitting TBR, since currently, the only way to really test this is to let it ...
5 years, 10 months ago (2015-02-10 18:43:17 UTC) #2
koda
Committed patchset #1 (id:1) manually as r43661 (presubmit successful).
5 years, 10 months ago (2015-02-10 18:43:33 UTC) #3
siva
5 years, 10 months ago (2015-02-10 19:27:46 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698