Issue 915083002: Reorder includes and remove platform/globals include

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 915083002: Reorder includes and remove platform/globals include (Closed)

Created:
5 years, 10 months ago by kustermann

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Reorder includes and remove platform/globals include TBR=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43693

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	dart/runtime/bin/eventhandler_test.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

This should fix the windows build. See e.g. here: http://chromegw.corp.google.com/i/client.dart/builders/vm-win64-release-be/builds/4891/steps/build/logs/stdio

5 years, 10 months ago (2015-02-11 17:24:24 UTC) #1

kustermann

Committed patchset #1 (id:1) manually as 43693 (presubmit successful).

5 years, 10 months ago (2015-02-11 17:24:46 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages