Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 915043002: dart2js: Track holders better when they are deferred. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Track holders better when they are deferred. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 7 chunks +7 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 10 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
We should eventually move the holders out of the Program (model) anyway, since it's something ...
5 years, 10 months ago (2015-02-11 15:29:19 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-02-12 08:09:06 UTC) #3
floitsch
5 years, 10 months ago (2015-02-16 09:08:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698