Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 915023002: check for null completion node (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

check for null completion node BUG=dartbug.com/22371 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43690

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +55 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years, 10 months ago (2015-02-11 13:47:24 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-11 15:40:39 UTC) #3
danrubel
5 years, 10 months ago (2015-02-11 15:44:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698