Add a VmListener and IsolateTest class for running tests in other isolates.

Add a VmListener and IsolateTest class for running tests in other isolates.

This also adds LiveTest.close, which releases resources associated with a
LiveTest.

R=kevmoo@google.com
See #2

Committed: https://github.com/dart-lang/unittest/commit/975fbfdb3112db314c4c36c5f1c348091985a572

[kevmoo, 2015-02-12 02:24:29]

https://codereview.chromium.org/914963003/diff/1/lib/src/isolate_test.dart
File lib/src/isolate_test.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/isolate_test.dart#ne...
lib/src/isolate_test.dart:5: library unittest.isolate_test;
Add this file to .status since it looks like a test

https://codereview.chromium.org/914963003/diff/1/lib/src/live_test_controller...
File lib/src/live_test_controller.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/live_test_controller...
lib/src/live_test_controller.dart:147: if (_isClosed) return;
return null here

...will make the analyzer happy since a return type is defined

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dart
File lib/src/remote_exception.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:32: /// Other than JSON- and isolate-safety, no
guarantees are made about the
Comments about what's expected for [error]?

String or object w/ 'message' property?

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:42: // Do nothing.
Fall back to message.toString()?

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:60: if (serialized['type'] == 'TestFailure') {
You could be a bit more clever coordinating between this method and serialize
WRT checking for an instance of TestFailure.

Are we telling folks not to subclass TestFailure, for instance?

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:81: class RemoteTestFailure implements
TestFailure, RemoteException {
Analyzer complains that this class does not implement _toString from
RemoteException

Ugh.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:83: final type = "TestFailure";
Could this be a property? Avoid allocating a String for each instance.

Also: type String

[nweiz, 2015-02-12 19:02:54]

Code review changes

[nweiz, 2015-02-12 19:03:41]

https://codereview.chromium.org/914963003/diff/1/lib/src/isolate_test.dart
File lib/src/isolate_test.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/isolate_test.dart#ne...
lib/src/isolate_test.dart:5: library unittest.isolate_test;
On 2015/02/12 02:24:29, kevmoo wrote:
> Add this file to .status since it looks like a test

Done.

https://codereview.chromium.org/914963003/diff/1/lib/src/live_test_controller...
File lib/src/live_test_controller.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/live_test_controller...
lib/src/live_test_controller.dart:147: if (_isClosed) return;
On 2015/02/12 02:24:29, kevmoo wrote:
> return null here
> 
> ...will make the analyzer happy since a return type is defined

Done.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dart
File lib/src/remote_exception.dart (right):

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:32: /// Other than JSON- and isolate-safety, no
guarantees are made about the
On 2015/02/12 02:24:29, kevmoo wrote:
> Comments about what's expected for [error]?
> 
> String or object w/ 'message' property?

Any error object—which is to say, theoretically any object at all—is allowed.
That's why it catches [NoMethodError] if [error.message] isn't defined.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:42: // Do nothing.
On 2015/02/12 02:24:29, kevmoo wrote:
> Fall back to message.toString()?

If we're here, there is no message property.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:60: if (serialized['type'] == 'TestFailure') {
On 2015/02/12 02:24:29, kevmoo wrote:
> You could be a bit more clever coordinating between this method and serialize
> WRT checking for an instance of TestFailure.
> 
> Are we telling folks not to subclass TestFailure, for instance?

Good point. Done.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:81: class RemoteTestFailure implements
TestFailure, RemoteException {
On 2015/02/12 02:24:29, kevmoo wrote:
> Analyzer complains that this class does not implement _toString from
> RemoteException
> 
> Ugh. 

Done.

https://codereview.chromium.org/914963003/diff/1/lib/src/remote_exception.dar...
lib/src/remote_exception.dart:83: final type = "TestFailure";
I removed this, but:

On 2015/02/12 02:24:29, kevmoo wrote:
> Could this be a property? Avoid allocating a String for each instance.

The language semantics don't define any difference between assigning a final
instance variable and defining a getter here. Given that, I'm only concerned
with which one reads better; if there's a meaningful performance difference,
it's the VM's job to choose the better implementation.

> Also: type String

The type is clear from the initializing expression.

[kevmoo, 2015-02-12 21:32:05]

lgtm

[nweiz, 2015-02-12 21:51:46]

Committed patchset #2 (id:20001) manually as
975fbfdb3112db314c4c36c5f1c348091985a572 (presubmit successful).