Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 914613002: Revert "Add sharedfrontend package" (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Add sharedfrontend package" This reverts commit r43635. BUG= Committed: https://code.google.com/p/dart/source/detail?r=43637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -490 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 4 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer2dart/lib/src/cps_generator.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/analyzer2dart/lib/src/identifier_semantics.dart View 8 chunks +266 lines, -142 lines 0 comments Download
M pkg/analyzer2dart/lib/src/semantic_visitor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer2dart/lib/src/tree_shaker.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 8 chunks +12 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/sharedfrontend/lib/elements.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/sharedfrontend/lib/src/access_semantics.dart View 1 chunk +0 lines, -264 lines 0 comments Download
D pkg/sharedfrontend/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR Apparently pathed dependencies don't work....
5 years, 10 months ago (2015-02-10 11:30:45 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 43637 (presubmit successful).
5 years, 10 months ago (2015-02-10 11:34:29 UTC) #3
Brian Wilkerson
5 years, 10 months ago (2015-02-10 14:48:59 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698