Use package: URIs for files in lib

Use package: URIs for files in lib

R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43827

[Brian Wilkerson, 2015-02-12 21:40:34]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-02-12 21:56:09]

https://codereview.chromium.org/914373004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/914373004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:306: if (createPackageUri) {
I think we could achieve the same effect with less effort by just doing this
logic unconditionally.  If the file is inside the package's "lib" folder, then
restoreUri() will return a "package:" URI for it.  If not, then it will fall
back to the ResourceUriResolver, which will just return the source's file URI.

The advantage of doing that would be that we don't have to hard code the name of
the "lib" directory (we get it from "pub list" instead), and we don't have to do
any bookkeeping inside this function to remember whether we're inside the "lib"
directory.

[Brian Wilkerson, 2015-02-13 17:46:08]

PTAL

https://codereview.chromium.org/914373004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/914373004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:306: if (createPackageUri) {
Your comment got me to thinking more deeply about this, and I became convinced
that we can't use the UriResolvers at all because they don't know about files in
their own package. I wrote a test to confirm that, and it failed as I expected
it to. I have re-written this slightly, but it's possible that there's still a
way to simplify the code.

[Brian Wilkerson, 2015-02-14 01:29:15]

Updated one more time. PTAL.

[Paul Berry, 2015-02-17 20:57:37]

On 2015/02/14 01:29:15, Brian Wilkerson wrote:
> Updated one more time. PTAL.

After in-person discussion, lgtm.  I hope that in the future we can simplify
this code along the lines I suggested in comment #3, but I don't want to block
progress in the short term.

[Brian Wilkerson, 2015-02-17 22:47:49]

Committed patchset #3 (id:40001) manually as 43827 (presubmit successful).