Fix yield statements in catch blocks

Fix yield statements in catch blocks

This is a partial fix for issue 22300. The VM no longer setfaults when
using yield in try statements. Yield in catch blocks work. What’s still
not working right is if a value is yielded before an exception is
propagated to the caller.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43707

[hausner, 2015-02-11 23:33:41]

hausner@google.com changed reviewers:
+ regis@google.com

[regis, 2015-02-11 23:53:45]

LGTM

https://codereview.chromium.org/914303006/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/914303006/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:5982: // This should always be true here.
Add a TODO if you want to revisit this code. Otherwise, remove the if statement
that duplicates the assert.

[hausner, 2015-02-12 00:11:15]

New patchsets have been uploaded after l-g-t-m from regis@google.com

[hausner, 2015-02-12 00:12:18]

Committed patchset #2 (id:20001) manually as r43707 (presubmit successful).

[hausner, 2015-02-12 00:18:50]

Thank you.

https://codereview.chromium.org/914303006/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/914303006/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:5982: // This should always be true here.
On 2015/02/11 23:53:44, regis wrote:
> Add a TODO if you want to revisit this code. Otherwise, remove the if
statement
> that duplicates the assert.

Removed the if. The assertion never fired in our tests.