Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 914203002: Add unittest for CircularLinkedList + bugfix (Closed)

Created:
5 years, 10 months ago by kustermann
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add unittest for CircularLinkedList + bugfix BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43691

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
M dart/runtime/bin/builtin_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M dart/runtime/bin/eventhandler.h View 3 chunks +8 lines, -1 line 0 comments Download
A dart/runtime/bin/eventhandler_test.cc View 1 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kustermann
Tested on linux.
5 years, 10 months ago (2015-02-11 15:52:54 UTC) #2
kustermann
5 years, 10 months ago (2015-02-11 16:06:34 UTC) #4
Bill Hesse
lgtm https://codereview.chromium.org/914203002/diff/1/dart/runtime/bin/eventhandler_test.cc File dart/runtime/bin/eventhandler_test.cc (right): https://codereview.chromium.org/914203002/diff/1/dart/runtime/bin/eventhandler_test.cc#newcode53 dart/runtime/bin/eventhandler_test.cc:53: // Test: Removing all items at once makes ...
5 years, 10 months ago (2015-02-11 16:17:21 UTC) #5
kustermann
Thanks. https://codereview.chromium.org/914203002/diff/1/dart/runtime/bin/eventhandler_test.cc File dart/runtime/bin/eventhandler_test.cc (right): https://codereview.chromium.org/914203002/diff/1/dart/runtime/bin/eventhandler_test.cc#newcode53 dart/runtime/bin/eventhandler_test.cc:53: // Test: Removing all items at once makes ...
5 years, 10 months ago (2015-02-11 16:19:52 UTC) #7
kustermann
Committed patchset #2 (id:20001) manually as 43691 (presubmit successful).
5 years, 10 months ago (2015-02-11 16:20:31 UTC) #8
Søren Gjesse
5 years, 10 months ago (2015-02-16 14:12:51 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698