Fix checked-mode return for async-functions.

Fix checked-mode return for async-functions.

BUG= dartbug.com/22332
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43719

[sigurdm, 2015-02-11 12:19:49]

sigurdm@google.com changed reviewers:
+ floitsch@google.com, johnniwinther@google.com

[floitsch, 2015-02-11 15:04:14]

LGTM with minor comments.

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:1062: bool get isAsync {
This would mean that the "SsaBuilder".isAsync.

Either change the name, or give it an argument. Eg:
bool get isBuildingAsyncFunction;
bool _isAsync(Element x)

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:5189: /// Returns `true` if [Future] is a
[type].
/// Returns true if the [type] is a valid return type for an asynchronous
function.
///
/// Asynchronous functions return a `Future`, and a valid return is thus either
dynamic, Object, or Future.
///
/// We do not accept the internal Future implementation class.

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:5190: bool isValidAsyncReturnType(type) {
Argument type is missing.

[sigurdm, 2015-02-12 09:30:07]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[sigurdm, 2015-02-12 09:35:56]

Committed patchset #2 (id:20001) manually as 43719 (presubmit successful).

[sigurdm, 2015-02-12 09:36:48]

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:1062: bool get isAsync {
On 2015/02/11 15:04:13, floitsch wrote:
> This would mean that the "SsaBuilder".isAsync.
> 
> Either change the name, or give it an argument. Eg:
> bool get isBuildingAsyncFunction;
> bool _isAsync(Element x)

Done.

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:5189: /// Returns `true` if [Future] is a
[type].
On 2015/02/11 15:04:13, floitsch wrote:
> /// Returns true if the [type] is a valid return type for an asynchronous
> function.
> ///
> /// Asynchronous functions return a `Future`, and a valid return is thus
either
> dynamic, Object, or Future.
> ///
> /// We do not accept the internal Future implementation class.

Done.

https://codereview.chromium.org/914143002/diff/1/pkg/compiler/lib/src/ssa/bui...
pkg/compiler/lib/src/ssa/builder.dart:5190: bool isValidAsyncReturnType(type) {
On 2015/02/11 15:04:13, floitsch wrote:
> Argument type is missing.

Done.