Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 914103002: Send destroy events for each closed listening socket instead of waiting for all listening sockets t… (Closed)

Created:
5 years, 10 months ago by kustermann
Modified:
5 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Send destroy events for each closed listening socket instead of waiting for all listening sockets to be done R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43680

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M dart/runtime/bin/eventhandler_win.cc View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
kustermann
Missed to add this to the previous CL.
5 years, 10 months ago (2015-02-11 11:21:49 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/914103002/diff/1/dart/runtime/bin/eventhandler_win.cc File dart/runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/914103002/diff/1/dart/runtime/bin/eventhandler_win.cc#newcode1035 dart/runtime/bin/eventhandler_win.cc:1035: DartUtils::PostInt32(msg->dart_port, 1 << kDestroyedEvent); DeleteIfClosed above sends a ...
5 years, 10 months ago (2015-02-11 11:31:21 UTC) #3
kustermann
https://codereview.chromium.org/914103002/diff/1/dart/runtime/bin/eventhandler_win.cc File dart/runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/914103002/diff/1/dart/runtime/bin/eventhandler_win.cc#newcode1035 dart/runtime/bin/eventhandler_win.cc:1035: DartUtils::PostInt32(msg->dart_port, 1 << kDestroyedEvent); On 2015/02/11 11:31:21, Søren Gjesse ...
5 years, 10 months ago (2015-02-11 11:32:56 UTC) #4
kustermann
5 years, 10 months ago (2015-02-11 11:34:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698