Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 913713002: Fix test to work on js-shell by avoiding a periodic timer. (Closed)

Created:
5 years, 10 months ago by sigurdm
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test to work on js-shell by avoiding a periodic timer. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43650

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M tests/language/await_for_cancel_test.dart View 1 4 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
5 years, 10 months ago (2015-02-10 14:58:25 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/913713002/diff/1/tests/language/await_for_cancel_test.dart File tests/language/await_for_cancel_test.dart (right): https://codereview.chromium.org/913713002/diff/1/tests/language/await_for_cancel_test.dart#newcode77 tests/language/await_for_cancel_test.dart:77: new Timer(const Duration(milliseconds: 0), tick); Timer.run(tick) https://codereview.chromium.org/913713002/diff/1/tests/language/await_for_cancel_test.dart#newcode81 tests/language/await_for_cancel_test.dart:81: ...
5 years, 10 months ago (2015-02-10 15:01:10 UTC) #3
sigurdm
https://codereview.chromium.org/913713002/diff/1/tests/language/await_for_cancel_test.dart File tests/language/await_for_cancel_test.dart (right): https://codereview.chromium.org/913713002/diff/1/tests/language/await_for_cancel_test.dart#newcode77 tests/language/await_for_cancel_test.dart:77: new Timer(const Duration(milliseconds: 0), tick); On 2015/02/10 15:01:09, floitsch ...
5 years, 10 months ago (2015-02-10 15:09:46 UTC) #4
sigurdm
5 years, 10 months ago (2015-02-10 15:10:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698