Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 913623002: Partial backport of analyzer async/await fixes to Java. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Partial backport of analyzer async/await fixes to Java. Backport of r43613, r43537, r43446, r43427, r43424, r43418, r43403, r43361 to the Java-based analyzer. The backport is partial in that the TypeProvider was not modified to include Future and Stream types (this would have required substantial additional effort), and consequently not all static warnings are correctly produced. However, all NonErrorResolverTest cases were successfully backported and pass, meaning that the Java-based analyzer shouldn't produce false positive warnings for async/await code anymore. BUG=dartbug.com/22252 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43655

Patch Set 1 #

Patch Set 2 : Fix status files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1166 lines, -56 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java View 2 chunks +40 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/BestPracticesVerifier.java View 2 chunks +16 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java View 3 chunks +50 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeProvider.java View 1 chunk +10 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeProviderImpl.java View 4 chunks +22 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 9 chunks +118 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/context/AnalysisContextFactory.java View 1 chunk +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzerTest.java View 5 chunks +83 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TestTypeProvider.java View 2 chunks +14 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java View 2 chunks +4 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/HintCodeTest.java View 1 chunk +11 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 6 chunks +509 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java View 5 chunks +261 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -13 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
5 years, 10 months ago (2015-02-10 01:21:40 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-10 01:44:25 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-10 16:05:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698