Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 913213002: Handle super calls to fields or getters that look like method calls. (Closed)

Created:
5 years, 10 months ago by asgerf
Modified:
5 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle super calls to fields or getters that look like method calls. These are of form: class A { get foo => {..} } class B extends A { m() { super.foo(1, 2, 3); } } BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=43909

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 1 chunk +32 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
Another bug that surfaced after the optional arguments change.
5 years, 10 months ago (2015-02-11 16:54:36 UTC) #2
karlklose
LGTM.
5 years, 10 months ago (2015-02-13 12:58:53 UTC) #3
asgerf
5 years, 10 months ago (2015-02-20 12:02:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698