Issue 913123006: Add a ConsoleReporter for printing human-friendly test progress reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 913123006: Add a ConsoleReporter for printing human-friendly test progress reports. (Closed)

Created:
5 years, 10 months ago by nweiz

Modified:
5 years, 10 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/unittest@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a ConsoleReporter for printing human-friendly test progress reports. No tests yet; since this uses stdout, I'm planning to wait until we have a runner executable and test that. R=kevmoo@google.com See #2 Committed: https://github.com/dart-lang/unittest/commit/6de347f85a4acfaeb581c3875b7523bf4e487208

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -0 lines)			Patch
	A	lib/src/console_reporter.dart	View		1 chunk	+205 lines, -0 lines	2 comments	Download
	A	lib/src/io.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/913123006/diff/1/lib/src/console_reporter.dart File lib/src/console_reporter.dart (right): https://codereview.chromium.org/913123006/diff/1/lib/src/console_reporter.dart#newcode54 lib/src/console_reporter.dart:54: : _multipleSuites = suites.length > 1, I hate ...

5 years, 10 months ago (2015-02-11 22:37:40 UTC) #2

nweiz

Committed patchset #1 (id:1) manually as 6de347f85a4acfaeb581c3875b7523bf4e487208 (presubmit successful).

5 years, 10 months ago (2015-02-11 23:10:48 UTC) #3

nweiz

5 years, 10 months ago (2015-02-11 23:34:43 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/913123006/diff/1/lib/src/console_reporter.dart
File lib/src/console_reporter.dart (right):

https://codereview.chromium.org/913123006/diff/1/lib/src/console_reporter.dar...
lib/src/console_reporter.dart:54: : _multipleSuites = suites.length > 1,
On 2015/02/11 22:37:39, kevmoo wrote:
> I hate length checks against Iterable -> causes a full enumeration
> 
> Could _multipleSuites be a property off Engine.liveTests.length?

Not really, since Engine.liveTests flattens across suites. You'd have to iterate
through and manually count the suites, which would be way worse than just
enumerating once here.

Expand Messages | Collapse Messages