Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 91293002: Propagate errors from DartUtils helper functions (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Propagate errors from DartUtils helper functions Instead of asserting in debug mode just propagate any errors. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30709

Patch Set 1 #

Patch Set 2 : Added intptr_t range check #

Patch Set 3 : Updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M runtime/bin/dartutils.h View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 6 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years ago (2013-11-27 11:32:24 UTC) #1
Anders Johnsen
LGTM
7 years ago (2013-11-27 11:44:42 UTC) #2
Søren Gjesse
7 years ago (2013-11-27 11:46:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r30709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698