Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 912293004: Let the CPS ir builder bail out when given a non-sync function. (Closed)

Created:
5 years, 10 months ago by sigurdm
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Let the CPS ir builder bail out when given a non-sync function. BUG= R=johnniwinther@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=43720

Patch Set 1 #

Patch Set 2 : Also giveup on nested async-functions, and update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 2 chunks +6 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sigurdm
5 years, 10 months ago (2015-02-11 15:01:29 UTC) #2
Johnni Winther
lgtm
5 years, 10 months ago (2015-02-11 18:26:54 UTC) #3
sigurdm
PTAL
5 years, 10 months ago (2015-02-12 09:08:26 UTC) #5
karlklose
LGTM.
5 years, 10 months ago (2015-02-12 09:30:29 UTC) #7
sigurdm
5 years, 10 months ago (2015-02-12 09:47:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43720 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698