Issue 91223002: Add support for Websocket protocols.

Issue 91223002: Add support for Websocket protocols. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for Websocket protocols. This also fixes an issue where idle sockets could keep the program alive. BUG=https://code.google.com/p/dart/issues/detail?id=14503 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30712

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Fix selecting invalid protocol and document. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -34 lines)			Patch
M	runtime/bin/socket_patch.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/websocket.dart	View	1 2	4 chunks	+26 lines, -8 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1 2	7 chunks	+59 lines, -23 lines	0 comments	Download
M	tests/standalone/io/socket_test.dart	View		2 chunks	+16 lines, -2 lines	0 comments	Download
A	tests/standalone/io/web_socket_protocol_test.dart	View	1 2	1 chunk	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm, with some doc. https://codereview.chromium.org/91223002/diff/20001/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/91223002/diff/20001/sdk/lib/io/websocket_impl.dart#newcode418 sdk/lib/io/websocket_impl.dart:418: } Please add a newline ...

7 years ago (2013-11-27 10:43:57 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/91223002/diff/20001/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/91223002/diff/20001/sdk/lib/io/websocket_impl.dart#newcode418 sdk/lib/io/websocket_impl.dart:418: } On 2013/11/27 10:43:58, Søren Gjesse wrote: > ...

7 years ago (2013-11-27 11:43:30 UTC) #3

Anders Johnsen

7 years ago (2013-11-27 12:10:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r30712 (presubmit successful).

Expand Messages | Collapse Messages