Issue 91103003: Use the integer type to get rid of above 0 checks in bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 91103003: Use the integer type to get rid of above 0 checks in bounds checks. (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
kasperl, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use the integer type to get rid of above 0 checks in bounds checks. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30705

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart	View		4 chunks	+15 lines, -16 lines	1 comment	Download
M	tests/compiler/dart2js/value_range2_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/compiler/dart2js/value_range3_test.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

7 years ago (2013-11-27 20:29:35 UTC) #4

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/91103003/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
(right):

https://codereview.chromium.org/91103003/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:296:
class PositiveValue extends InstructionValue {
Zero is possible, but is not positive.
Perhaps leave it as "LengthValue", or rename to "Nonnegative" or some other
term.

Expand Messages | Collapse Messages